feat: Do not cache health checks per default #2335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
When using the `@HealthCheck` decorator
it will now per default set the following header:
`Cache-Control: no-cache, no-store, must-revalidate`
To disable this behavior set `@HealthCheck({ noCache: false })`
resolves #2328
BrunnerLivio
force-pushed
the
feature/cache-control
branch
from
defa614 to
827c436
Compare
|
If you have time, I'd appreciate your review @Tony133 :) |
BrunnerLivio
added a commit
that referenced
this pull request
Sep 14, 2023
When using the `@HealthCheck` decorator
it will now per default set the following header:
`Cache-Control: no-cache, no-store, must-revalidate`
To disable this behavior set `@HealthCheck({ noCache: false })`
resolves #2328
BrunnerLivio
added a commit
that referenced
this pull request
Sep 14, 2023
When using the `@HealthCheck` decorator
it will now per default set the following header:
`Cache-Control: no-cache, no-store, must-revalidate`
To disable this behavior set `@HealthCheck({ noCache: false })`
resolves #2328
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #2328
What is the new behavior?
When using the
@HealthCheckdecoratorit will now per default set the following header:
Cache-Control: no-cache, no-store, must-revalidateTo disable this behavior set
@HealthCheck({ noCache: false })Does this PR introduce a breaking change?
Other information